Skip to content

fix(cli): openAPI generator should update index files. Add relation interfaces to model template.#4469

Merged
agnes512 merged 2 commits into
masterfrom
openapi-generator
Jan 22, 2020
Merged

fix(cli): openAPI generator should update index files. Add relation interfaces to model template.#4469
agnes512 merged 2 commits into
masterfrom
openapi-generator

Conversation

@agnes512

@agnes512 agnes512 commented Jan 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes: #4135

  • The first commit refactors openapi cli tests with snapshot
  • The second commit fixes the generator so that the index files get updated correctly. Also adds relation interface to the openAPI model template so that when it generates repositories from these models, it won't complain that xxxRelations doesn't exist.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512
agnes512 force-pushed the openapi-generator branch 2 times, most recently from c128711 to 6e6b206 Compare January 21, 2020 15:17
@agnes512 agnes512 changed the title fix(cli): openAPI generator should update index file. Add relation interface to model template. fix(cli): openAPI generator should update index files. Add relation interfaces to model template. Jan 21, 2020
@achrinza achrinza added the CLI label Jan 22, 2020
@agnes512
agnes512 merged commit 7fd9b88 into master Jan 22, 2020
@agnes512
agnes512 deleted the openapi-generator branch January 22, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes
@nabdelgadir nabdelgadir nabdelgadir approved these changes
@bajtos bajtos Awaiting requested review from bajtos

Assignees

No one assigned

Labels

CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing models/index.ts after running lb4 openapi command

4 participants

@agnes512 @raymondfeng @nabdelgadir @achrinza